On 9/19/20 6:19 AM, Vinod Koul wrote:
On 18-09-20, 09:21, Pierre-Louis Bossart wrote:
* Base file is device
* |---- modalias
+ * |---- dev-status
+ * |---- status
+ * |---- device_number
Any reason why we want this under dev-status.
Both the status and device_number belong to the device, so we can
put them under device and use device properties
We already use directories for device-level and port-level properties, I
just thought it be cleaner to continue this model. We might also expand the
information later on, e.g. provide interrupt status.
Right now we have directories for N ports (needs a dir due to nature of
N ports) and 'properties' derived from Disco/firmware.
So Nport and properties makes sense. But for generic device level stuff
like device number, status and future interrupt or anything should be at
device level.
I don't mind if we remove the directory and move everything up one level,
but it wouldn't be consistent with the previous work.
Just because we had directory for a reason, adding a directory to
conform to that does make it better. IMO device files should be at
device directory
We have a "dev-properties" directory, which is added after the driver
probe, and describes MIPI DisCo values at the device level.
Either we remove this dev-properties and move it to the device level -
to be consistent with your recommendation - or we keep separate
directories, one which is populated on device registration and the other
on driver probe.
