RE: [PATCH v5 02/13] ASoC: Intel: catpt: Define DSP operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-09-18 3:52 PM, Andy Shevchenko wrote:
> On Thu, Sep 17, 2020 at 03:29:36PM +0000, Rojewski, Cezary wrote:
>> On 2020-09-16 5:44 PM, Andy Shevchenko wrote:
>>> On Tue, Sep 15, 2020 at 06:29:33PM +0200, Cezary Rojewski wrote:
> 
> ...
> 
>>>> +	dmac->regs = cdev->lpe_ba +
>>>> +		     cdev->spec->host_dma_offset[CATPT_DMA_DEVID];
>>>
>>> One line?
>>>
>> It's exactly 81 after one-lining - that's why I kept it as is.
> 
> And 81 is okay when there is better readability.
> 
> I'm wondering why you don't go 100...
> 
> In any case it's not a reason to resend.
>

As I'll be sending v7, this nitpick will be addressed there too.

Thanks,
Czarek





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux