On Thu, Sep 17, 2020 at 11:00:07AM -0500, Pierre-Louis Bossart wrote: > The MIPI DisCo device properties that are read by the driver from > platform firmware, or hard-coded in the driver, should only be > provided as sysfs entries when a driver probes successfully. > > However the device status and device number is updated even when there > is no driver present, and hence can be updated when a Slave device is > detected on the bus without being described in platform firmware and > without any driver registered/probed. > > As suggested by GregKH, the attribute group for Slave status and > device number is is added by default upon device registration. > > Credits to Vinod Koul for the status_show() function, shared in a > separate patch and used as is here. The status table was modified to > remove an unnecessary enum and status_show() is handled in a different > group attribute than what was suggested by Vinod. > > Tested-by: Srinivas Kandgatla <srinivas.kandagatla@xxxxxxxxxx> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > --- > .../ABI/testing/sysfs-bus-soundwire-slave | 18 ++++++ > drivers/soundwire/slave.c | 2 + > drivers/soundwire/sysfs_local.h | 4 ++ > drivers/soundwire/sysfs_slave.c | 59 ++++++++++++++++++- > 4 files changed, 82 insertions(+), 1 deletion(-) Much nicer, thanks for the change: Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
