On 9/17/20 8:06 AM, Mark Brown wrote:
On Thu, Sep 17, 2020 at 08:00:39AM -0500, Pierre-Louis Bossart wrote:
On 9/17/20 6:25 AM, Mark Brown wrote:
Normally we would just add a delay in the driver unconditionally, why
make this a module paramter? If there are board variations then we
should be getting them from board data, not forcing individual users to
bodge things with a module parameter.
that wasn't the intent. 400ms is the recommended value, but the parameter
provides a way to experiment without having to recompile during
integration/debug stages.
It was my recommendation to add this parameter, I don't mind removing it if
you prefer it that way. Or I can respin the commit message and comments to
make it clearer what the intended use was.
It'd be better to just remove it. If you want a facility to experiment
for testing debugfs is a better fit I think, unless this is a delay that
only gets done once during probe of course in which case that wouldn't
work.
ok, I'll send a v2.
