Thanks for the review Greg,
+int sdw_slave_status_sysfs_init(struct sdw_slave *slave) +{ + return device_add_group(&slave->dev, &sdw_slave_status_attr_group);DOesn't this race with userspace? Why not make this part of the default set of device attributes and have the driver core create them automatically?
What did you mean by 'default set of device attributes', would you mind providing a pointer to an example so that I can look into this?
What we have in this patch is added by the SoundWire core but you're probably thinking of something else. thanks for enlightening the rest of us:-)
