On Wed, Sep 9, 2020 at 7:17 PM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > > > Hi Rob > > Thank you for your feedback > > > > diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card.yaml > > > new file mode 100644 > > > index 000000000000..60d7b1504128 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/sound/audio-graph-card.yaml > > > @@ -0,0 +1,135 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/sound/audio-graph-card.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Audio Graph Card Driver Device Tree Bindings > > > + > > > +maintainers: > > > + - Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > + > > > +definitions: > > > > Please don't use 'definitions' unless really needed. There's only 1 > > reference to 'endpoint' and 'port' so you don't here. > > If this was applied, all audio-graph-card user driver want to use it. They should reference this schema at the top level, not down in it. Rob
