Dne 28. 08. 20 v 8:51 Vinod Koul napsal(a): > Hi Mark, > > On 18-08-20, 22:06, Bard Liao wrote: >> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> >> >> Add a slave-level property and program the SCP_INT1_MASK as desired by >> the codec driver. Since there is no DisCo property this has to be an >> implementation-specific firmware property or hard-coded in the driver. >> >> The only functionality change is that implementation-defined >> interrupts are no longer set for amplifiers - those interrupts are >> typically for jack detection or acoustic event detection/hotwording. >> >> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> >> Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx> >> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@xxxxxxxxxxxxxxx> >> Signed-off-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> >> --- >> drivers/soundwire/bus.c | 12 ++++++------ >> include/linux/soundwire/sdw.h | 2 ++ >> sound/soc/codecs/max98373-sdw.c | 3 +++ >> sound/soc/codecs/rt1308-sdw.c | 2 ++ >> sound/soc/codecs/rt5682-sdw.c | 4 ++++ >> sound/soc/codecs/rt700-sdw.c | 4 ++++ >> sound/soc/codecs/rt711-sdw.c | 4 ++++ >> sound/soc/codecs/rt715-sdw.c | 4 ++++ >> sound/soc/codecs/wsa881x.c | 1 + > > This touches codecs, can you Ack it please Mark, could you ack the ASoC change to accept this patch via the soundwire repo? > > Ideally this should have been split up to header, the codec updates and > finally the bus change! I don't think that the split is ideal in this case. I tested the code and it looks straight enough. Acked-by: Jaroslav Kysela <perex@xxxxxxxx> -- Jaroslav Kysela <perex@xxxxxxxx> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
