Re: [PATCH] ALSA: hda: release resource when snd_hdac_device_init is failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Wed, 2 Sep 2020, Takashi Iwai wrote:

> On Wed, 02 Sep 2020 17:42:29 +0200, Kai Vehmanen wrote:
> > When snd_hdac_device_init is failed, the codec is released by kfree
> > immediately without releasing some resources. The vendor_name should
> 
> It's released via put_device() and this should call the release
> callback, default_release(), and it contains all those kfree()'s and
> pm_runtime_*().
> 
> Could you double-check whether it's really missing?

ack, thanks for spotting. put_device() indeed calls the default release,
so this patch is not correct.

Rander, can you check as well this matches with the scenario you were 
looking at?

Br, Kai



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux