Re: [PATCH v2 0/3] regmap: add SoundWire 1.2 MBQ support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/3/20 5:36 AM, Vinod Koul wrote:
On 01-09-20, 11:22, Pierre-Louis Bossart wrote:
In preparation of the upstream contribution of SDCA (SoundWire Device
Class for Audio) ASoC codec drivers [1] [2], add regmap support
SoundWire 1.2 MBQ support. The MBQ (Multi-Byte Quantity) registers
need to be handled in a different way from regular 8-bit SoundWire
registers, their main application is going to be for volume/gain
controls.

The second patch was initially suggested for inclusion in the
SoundWire tree, and was modified to add more background information on
SDCA in the commit message as requested by Vinod Koul.

Is this targetted towards the sdw tree or regmap tree, I think it may
have dependencies so sdw can be used.

It would be nice to mention these things here in cover

It was intended for the regmap tree (the cover letter does not include the soundwire: prefix).

Patch2 would need the ack of SoundWire maintainers (Bard already provide his tag).

The dependencies are regmap->ASoC for codec integration. There will be no dependencies for the SoundWire core proper, SDCA is really about the device side of things beyond what the bus provides.

Thanks!



Changes since v1:
Rebased on regmap tree (conflict with SPI stuff).
Removed mod_devicetable.h header
Removed -EOPNOTSUPP error codes, use -ENOTSUPP
Added long description of SDCA
Used FIELD_PREP/GET as suggested by Vinod Koul
Added Bard Liao's Acked-by tag.

Pierre-Louis Bossart (3):
   regmap: sdw: add required header files
   soundwire: SDCA: add helper macro to access controls
   regmap: sdw: add support for SoundWire 1.2 MBQ

  drivers/base/regmap/Kconfig             |   6 +-
  drivers/base/regmap/Makefile            |   1 +
  drivers/base/regmap/regmap-sdw-mbq.c    | 101 ++++++++++++++++++++++++
  drivers/base/regmap/regmap-sdw.c        |   2 +
  include/linux/regmap.h                  |  21 +++++
  include/linux/soundwire/sdw_registers.h |  33 ++++++++
  6 files changed, 163 insertions(+), 1 deletion(-)
  create mode 100644 drivers/base/regmap/regmap-sdw-mbq.c


base-commit: d17343b87da422a59d99a3ed130573dbeb96c582
--
2.25.1




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux