Re: [PATCH] ALSA: hda: add dev_dbg log when driver is not selected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 02 Sep 2020 17:42:39 +0200,
Kai Vehmanen wrote:
> 
> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> 
> On SKL+ Intel platforms, the driver selection is handled by the
> snd_intel_dspcfg, and when the HDaudio legacy driver is not selected,
> be it with the auto-selection or user preferences with a kernel
> parameter, the probe aborts with no logs, only a -ENODEV return value.
> 
> Having no dmesg trace, even with dynamic debug enabled, makes support
> more complicated than it needs to be, and even experienced users can
> be fooled. A simple dev_dbg() trace solves this problem.
> 
> BugLink: https://github.com/thesofproject/linux/issues/2330
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> Reviewed-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@xxxxxxxxxxxxxxx>
> Signed-off-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>

Applied now.  Thanks.


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux