On 31-08-20, 10:15, Pierre-Louis Bossart wrote: > > > > > > > > Detect cases where the clock is assumed to be stopped but the IP is > > > > > > > not in the relevant state, and add a dynamic debug trace. > > > > > > > > > > > > you meant a debug print..and it looks like error print below (also in title). > > > > > > > > > > I don't understand the comment. Is the 'trace' confusing and are you asking > > > > > to e.g. change the commit message to 'add dynamic debug log'? > > > > > > > > Question is what is dynamic about this? > > > dev_dbg() is part of the kernel dynamic debug capability... > > > > > > https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html > > > > > > Not sure what you are asking here? > > > > :-| where is dev_dbg() ? > > > > See [1] > > > > > [1] > > > > > + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__); > > > > ^^^^^^^ > > it's still a log using the "dynamic debug" framework. > > Again, what are you asking us to fix? Ah you are really testing my patience! The title says "dynamic debug" and then you use a dev_err which is *not* part of dynamic debug as it is printed always and cannot be dynamically enabled and disabled! See Documentation/admin-guide/dynamic-debug-howto.rst: "Dynamic debug is designed to allow you to dynamically enable/disable kernel code to obtain additional kernel information. Currently, if ``CONFIG_DYNAMIC_DEBUG`` is set, then all ``pr_debug()``/``dev_dbg()`` and ``print_hex_dump_debug()``/``print_hex_dump_bytes()`` calls can be dynamically enabled per-callsite." No dev_err here! -- ~Vinod
