On Sat, Aug 22, 2020 at 6:48 AM Alper Nebi Yasak <alpernebiyasak@xxxxxxxxx> wrote: > > Hi, I'm not really a kernel person, but wanted to point out an > alternative I think is better. > > On 21/08/2020 02:32, Curtis Malainey wrote: > > Some codecs can differentiate headsets based on the number of rings. > > Should we choose to differentiate the config we will need to be able to > > select based on the jack event code. > > AFAICT from ChromiumOS UCM configs, you're using JackSwitch to detect > whether a plugged-in jack is/has headphones, a headset mic, or line-out. > Instead, if you add something like my recent commit d0508b4f1604 ("ASoC: > rk3399_gru_sound: Add DAPM pins, kcontrols for jack detection") to the > machine drivers, you can just use JackControl to specify them in your > UCM files, and your audio server could distinguish between those cases > by the values of the jack kcontrols (e.g. PulseAudio already can). Typically we use JackDev over JackControl, and this would add similar support to what you added but within the context of using an input device instead of an ALSA jack.