hi Hui Wang
Lt is Lenovo A630z TIO built-in usb sound card,
Thanks,
penghao
ç»ä¿¡è½¯ä»¶ææ¯æéå¬å¸
UnionTech Software Technology Co., Ltd. ã
å®ç½ï¼www.uniontech.comãã
æ¤çµåé®ä»¶æ¶æ¯ä»ä¾é¢ææ¶ä»¶äººä½¿ç¨ï¼å¶ä¸å¯è½åå«ä¿å¯æç¹æ使ç¨ä¿¡æ¯ãå¦ææ¨
ä¸æ¯é¢ææ¶ä»¶äººï¼è¯·å¿ä½¿ç¨ãä¼ æãååæå¤å¶æ¤çµåé®ä»¶æä¿¡èµæ¤é®ä»¶éåä»»ä½è
¡å¨ãå¦ææ¨è¯¯æ¶äºæ¤é®ä»¶ï¼è¯·ç«å³åå¤é®ä»¶éç¥ç»ä¿¡è½¯ä»¶ææ¯æéå¬å¸å件人ï
¼å¹¶å é¤è¯¯æ¶çµåé®ä»¶åå¶ç¸å³é件ãæè°¢éåï¼
This email message is intended only for the use of the individual or
entity who/which is the intended recipient and may contain information
that is privileged or confidential. If you are not the intended
recipient, you are hereby notified that any use, dissemination,
distribution or copying of, or taking any action in reliance on, this
e-mail is strictly prohibited. If you have received this email in
error, please notify UnionTech Software Technology immediately by
replying to this e-mail and immediately delete and discard all copies
of the e-mail and the attachment thereto (if any). Thank you.
From: "Hui Wang <hui.wang@xxxxxxxxxxxxx>"
To: "Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>","Takashi Iwai
<tiwai@xxxxxxx>"
CC: "moderated list:SOUND <alsa-devel@xxxxxxxxxxxxxxxx>","penghao
<penghao@xxxxxxxxxxxxx>","linux-kernel
<linux-kernel@xxxxxxxxxxxxxxx>","crwulff
<crwulff@xxxxxxxxx>","gustavoars <gustavoars@xxxxxxxxxx>","alexander
<alexander@xxxxxxx>","Mark Pearson
<mpearson@xxxxxxxxxx>","dan.carpenter <dan.carpenter@xxxxxxxxxx>"
Sent: 2020-08-20 09:42
Subject: Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state
trig byLenovo ThinkCentre TI024Gen3 USB-audio
On 2020/8/20 ä¸å2:10, Kai-Heng Feng wrote:
>
>> On Aug 20, 2020, at 01:18, Takashi Iwai <tiwai@xxxxxxx> wrote:
>>
>> [ Adding a few more relevant people to Cc. ]
>>
>> On Wed, 19 Aug 2020 13:57:57 +0200,
>> penghao wrote:
>>> TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens
>>> enter sleep mode, USB-audio will disconnect from USB bus port,
>>> wakup form s3 state
>>>
>>> Signed-off-by: penghao <penghao@xxxxxxxxxxxxx>
>>> ---
>>> sound/usb/card.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/sound/usb/card.c b/sound/usb/card.c
>>> index 696e788c5d31..6bdbb34009b3 100644
>>> --- a/sound/usb/card.c
>>> +++ b/sound/usb/card.c
>>> @@ -658,6 +658,12 @@ static int usb_audio_probe(struct
usb_interface *intf,
>>> }
>>>
>>> dev_set_drvdata(&dev->dev, chip);
>>> + /*
>>> + *ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo
>>> + *ThinkCentre TI024Gen3 usb-audio
>>> + */
>>> + if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct ==
0xa012))
>>> + device_set_wakeup_enable(ï¼dev->dev, 0);
>> Here it's no proper ASCII letter, and this must be broken.
>> Please check the actual patch before submitting.
>>
>> In anyway, before going further, I'd like to hear from other people
>> whether this is really mandatory and appropriate. And whether it's
>> specific to that device, too (not other Lenovo devices?)
> If USB remote wakeup on this device is broken then we need to fix it
in USB core instead of USB audio.
> We need USB and xHCI logs to understand the real problem here, the
commit message doesn't contain enough information.
>
> Kai-Heng
I checked with our QA, we didn't enable this machine before. And I
tried 2 different usb audio cards, neither of them has wakeup
capability. it is weird that your usb sound card (maybe a built-in usb
sound card) has wakeup capability.
You could file a bug to
[1]https://bugs.launchpad.net/ubuntu/+source/linux/+filebug, then
upload
the needed logs, Kai-Heng and I will help investigate this issue.
Thanks,
Hui.
>>
>> thanks,
>>
>> Takashi
References
1. https://bugs.launchpad.net/ubuntu/+source/linux/+filebug,
