On Thu, 2020-08-13 at 16:44 +0100, Mark Brown wrote: > On Thu, Aug 13, 2020 at 11:40:00PM +0800, Jiaxin Yu wrote: > > On Wed, 2020-08-12 at 13:05 +0100, Mark Brown wrote: > > > > These functions are exported for other drivers to use rather than > > > something done internally by the driver - if this were internal to the > > > driver it'd not be a big deal but when it's for use by another driver > > > it'd be better to go through standard interfaces. > > > Can we move this part of the operation to the codec dai driver ops, such > > as .startup and .shutdown? Because originally these functions are > > exported to machine driver's dai_link .startup and .shutdown ops. > > If it's internal to the driver sure. > > > > So this needs the SoC to do something as part of callibration? > > > Yes, the side of MTKAIF in SoC part named adda, we need config it before > > calibration. We will also upstream machine/platform driver that use this > > codec driver later. > > It would probably be better to just leave this out for now then add the > required bits to the CODEC driver as part of a patch series that also > adds the machine driver that uses it so it's clear how it all fits > together. It sounds like it should be fine but this'd be easier to > review. Ok, I'll remove the functions that related to the calibration, and upstream them again as part of a patch series that adds the machine driver later.
