On Thu, Aug 13, 2020 at 02:43:50PM -0500, Pierre-Louis Bossart wrote: > On 8/13/20 1:45 PM, Mark Brown wrote: > > On Thu, Aug 13, 2020 at 12:58:39PM -0500, Pierre-Louis Bossart wrote: > > > - hdmi_num = sof_sdw_quirk & SOF_SDW_TGL_HDMI ? > > > + hdmi_num = (sof_sdw_quirk & SOF_SDW_TGL_HDMI) ? > > > SOF_TGL_HDMI_COUNT : SOF_PRE_TGL_HDMI_COUNT; > > Or better yet, just don't abuse the ternery operator like this and write > > normal conditional statements. > I count 795 uses of the ternary operator in sound/soc and 68776 in my local > kernel branch. > Can you clarify in what way this is an abuse? I don't mind changing this, I > wasn't aware this is frowned upon. If you write a normal conditional statement then not only is the precedence clear but it's just generally easier to read. There are cases where it can help make things clearer (eg, avoiding the use of scratch variables to hold results) but this is most definitely not one of them and I don't understand everyone's enthusiasm for trying to put them in.
Attachment:
signature.asc
Description: PGP signature
