Re: [PATCH v3 09/13] ASoC: Intel: Select catpt and deprecate haswell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Cezary,

I love your patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on sound/for-next v5.8 next-20200811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cezary-Rojewski/ASoC-Intel-Catpt-Lynx-and-Wildcat-point/20200812-002100
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from sound/soc/intel/catpt/core.h:14,
                    from sound/soc/intel/catpt/dsp.c:12:
   sound/soc/intel/catpt/dsp.c: In function 'catpt_dsp_stall':
>> sound/soc/intel/catpt/registers.h:168:32: error: 'CATPT_SHIM_REG_13' undeclared (first use in this function); did you mean 'CATPT_SHIM_REG_CS'?
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:229:2: note: in expansion of macro 'catpt_updatel_shim'
     229 |  catpt_updatel_shim(cdev, CS, CATPT_CS_STALL, val);
         |  ^~~~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:168:32: note: each undeclared identifier is reported only once for each function it appears in
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:229:2: note: in expansion of macro 'catpt_updatel_shim'
     229 |  catpt_updatel_shim(cdev, CS, CATPT_CS_STALL, val);
         |  ^~~~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c: In function 'catpt_dsp_reset':
>> sound/soc/intel/catpt/registers.h:168:32: error: 'CATPT_SHIM_REG_13' undeclared (first use in this function); did you mean 'CATPT_SHIM_REG_CS'?
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:241:2: note: in expansion of macro 'catpt_updatel_shim'
     241 |  catpt_updatel_shim(cdev, CS, CATPT_CS_RST, val);
         |  ^~~~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c: In function 'catpt_dsp_select_lpclock':
>> sound/soc/intel/catpt/registers.h:168:32: error: 'CATPT_SHIM_REG_13' undeclared (first use in this function); did you mean 'CATPT_SHIM_REG_CS'?
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:302:2: note: in expansion of macro 'catpt_updatel_shim'
     302 |  catpt_updatel_shim(cdev, CS, mask, val);
         |  ^~~~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c: In function 'lpt_dsp_power_down':
>> sound/soc/intel/catpt/registers.h:168:32: error: 'CATPT_SHIM_REG_13' undeclared (first use in this function); did you mean 'CATPT_SHIM_REG_CS'?
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:374:2: note: in expansion of macro 'catpt_updatel_shim'
     374 |  catpt_updatel_shim(cdev, CS, CATPT_CS_SBCS(0) | CATPT_CS_SBCS(1),
         |  ^~~~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c: In function 'lpt_dsp_power_up':
>> sound/soc/intel/catpt/registers.h:168:32: error: 'CATPT_SHIM_REG_13' undeclared (first use in this function); did you mean 'CATPT_SHIM_REG_CS'?
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:402:2: note: in expansion of macro 'catpt_updatel_shim'
     402 |  catpt_updatel_shim(cdev, CS,
         |  ^~~~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c: In function 'wpt_dsp_power_down':
>> sound/soc/intel/catpt/registers.h:168:32: error: 'CATPT_SHIM_REG_13' undeclared (first use in this function); did you mean 'CATPT_SHIM_REG_CS'?
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:423:2: note: in expansion of macro 'catpt_updatel_shim'
     423 |  catpt_updatel_shim(cdev, CS, CATPT_CS_SBCS(0) | CATPT_CS_SBCS(1),
         |  ^~~~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c: In function 'wpt_dsp_power_up':
>> sound/soc/intel/catpt/registers.h:168:32: error: 'CATPT_SHIM_REG_13' undeclared (first use in this function); did you mean 'CATPT_SHIM_REG_CS'?
     168 |  readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |                                ^~~~~~~~~~~~~~~
   sound/soc/intel/catpt/registers.h:170:9: note: in definition of macro 'catpt_writel_shim'
     170 |  writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
         |         ^~~
   sound/soc/intel/catpt/registers.h:173:5: note: in expansion of macro 'catpt_readl_shim'
     173 |    (catpt_readl_shim(cdev, reg) & ~(mask)) | val)
         |     ^~~~~~~~~~~~~~~~
   sound/soc/intel/catpt/dsp.c:486:2: note: in expansion of macro 'catpt_updatel_shim'
     486 |  catpt_updatel_shim(cdev, CS, CATPT_CS_SBCS(0) | CATPT_CS_SBCS(1),
         |  ^~~~~~~~~~~~~~~~~~

vim +168 sound/soc/intel/catpt/registers.h

91c02b85c1c0fa Cezary Rojewski 2020-08-11  152  
91c02b85c1c0fa Cezary Rojewski 2020-08-11  153  #define catpt_shim_addr(cdev) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  154  	((cdev)->lpe_ba + (cdev)->spec->host_shim_offset)
91c02b85c1c0fa Cezary Rojewski 2020-08-11  155  #define catpt_dma_addr(cdev, dma) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  156  	((cdev)->lpe_ba + (cdev)->spec->host_dma_offset[dma])
91c02b85c1c0fa Cezary Rojewski 2020-08-11  157  #define catpt_ssp_addr(cdev, ssp) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  158  	((cdev)->lpe_ba + (cdev)->spec->host_ssp_offset[ssp])
91c02b85c1c0fa Cezary Rojewski 2020-08-11  159  #define catpt_inbox_addr(cdev) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  160  	((cdev)->lpe_ba + (cdev)->ipc.config.inbox_offset)
91c02b85c1c0fa Cezary Rojewski 2020-08-11  161  #define catpt_outbox_addr(cdev) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  162  	((cdev)->lpe_ba + (cdev)->ipc.config.outbox_offset)
91c02b85c1c0fa Cezary Rojewski 2020-08-11  163  
91c02b85c1c0fa Cezary Rojewski 2020-08-11  164  #define catpt_writel_ssp(cdev, ssp, reg, val) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  165  	writel(val, catpt_ssp_addr(cdev, ssp) + CATPT_SSP_##reg)
91c02b85c1c0fa Cezary Rojewski 2020-08-11  166  
91c02b85c1c0fa Cezary Rojewski 2020-08-11  167  #define catpt_readl_shim(cdev, reg) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11 @168  	readl(catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
91c02b85c1c0fa Cezary Rojewski 2020-08-11  169  #define catpt_writel_shim(cdev, reg, val) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  170  	writel(val, catpt_shim_addr(cdev) + CATPT_SHIM_REG_##reg)
91c02b85c1c0fa Cezary Rojewski 2020-08-11  171  #define catpt_updatel_shim(cdev, reg, mask, val) \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  172  	catpt_writel_shim(cdev, reg, \
91c02b85c1c0fa Cezary Rojewski 2020-08-11  173  			(catpt_readl_shim(cdev, reg) & ~(mask)) | val)
91c02b85c1c0fa Cezary Rojewski 2020-08-11  174  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux