Re: [PATCH 07/13] ASoC: Intel: catpt: Event tracing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-08-10 9:16 AM, Cezary Rojewski wrote:
On 2020-08-07 5:09 PM, Mark Brown wrote:
On Fri, Aug 07, 2020 at 01:06:43PM +0200, Cezary Rojewski wrote:
Define tracing macros for easy catpt debug. These are divided into
memory, registry and ipc event categories.

Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
---
  sound/soc/intel/catpt/trace.h | 169 ++++++++++++++++++++++++++++++++++

Usually events go into include/trace/events/


Thought TRACE_INCLUDE_FILE/ _PATH are designed specifically to remove the need for trace.h to go into mentioned folder. Based my decision on fact that sound/hda and sound/core have their traces defined locally.

What's the preferred way?


In regard to preferences, one more question Mark, if I may:
	snd_soc_catpt vs snd_soc_intel_catpt

while developers usually prefer the shorter ones, I understand there might be some subsystem level preferences and currently chosen name could have easily slipped reviewers given the length of patchset.

Czarek



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux