-----Original Message----- From: Mark Brown <broonie@xxxxxxxxxx> Sent: Thursday, August 6, 2020 4:59 PM To: RAVULAPATI, VISHNU VARDHAN RAO <Vishnuvardhanrao.Ravulapati@xxxxxxx> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Agrawal, Akshu <Akshu.Agrawal@xxxxxxx>; Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>; YueHaibing <yuehaibing@xxxxxxxxxx>; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... <alsa-devel@xxxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx> Subject: Re: [PATCH] ASoC: amd: Replacing component->name with codec_dai->name On Thu, Aug 06, 2020 at 03:44:12PM +0530, Ravulapati Vishnu vardhan rao wrote: > Replacing string compare with codec_dai->name instead of comparing > with codec_dai->component->name in hw_params. >Why? Here the component name for codec RT1015 is "i2c-10EC5682:00" and will never be "rt1015-aif1" As it is codec-dai->name so the strcmp always compares and fails to set the sysclk,pll,bratio of expected codec-dai Thanks, Vishnu