> On Thu, Jul 30, 2020 at 04:13:35PM +0800, Brent Lu wrote: > > From: Yu-Hsuan Hsu <yuhsuan@xxxxxxxxxxxx> > > > > The CRAS server does not set the period size in hw_param so ALSA will > > calculate a value for period size which is based on the buffer size > > and other parameters. The value may not always be aligned with Atom's > > dsp design so a constraint is added to make sure the board always has > > a good value. > > > > Cyan uses chtmax98090 and others(banon, celes, edgar, kefka...) use > > rt5650. > > Actually one more comment here. > Can you split per machine driver? > It adds constraints on BSW Chromebooks for same purpose. I don't see the benefit to split it. Regards, Brent > > sound/soc/intel/boards/cht_bsw_max98090_ti.c | 14 +++++++++++++- > > sound/soc/intel/boards/cht_bsw_rt5645.c | 14 +++++++++++++- > > -- > With Best Regards, > Andy Shevchenko >