On 7/7/2020 4:00 PM, Mark Brown wrote:
On Tue, Jul 07, 2020 at 03:38:25PM +0530, Akshu Agrawal wrote:
Non-dts based systems can use ACPI DSDT to pass on the mclk.
Thus add fmw property mclk-name to get the name of the system clk
and link it to rt5682 mclk.
ACPI doesn't support clocks at all, you need to add a clock binding to
ACPI first. The idiomatic way to do this would be to have board
specific quirks.
clk binding is present for AMD ST platform and using the same.
With recent submitted patches I am making them generic for all AMD
platforms.
Please refer patches:
https://patchwork.kernel.org/patch/11658505/
https://patchwork.kernel.org/patch/11658507/
Thanks,
Akshu
+ device_property_read_string(dev, "realtek,mclk-name", &rt5682->pdata.mclk_name);
+
No, this is not at all OK - you're adding this via a device property
which means that this will show up in the DT bindings too.
