On Thu, Jul 09, 2020 at 01:17:49PM +0200, Takashi Iwai wrote:
> The "fall through" comments found in switch-cases in ALSA xen driver
> are all superfluous. The kernel coding style allows the multiple
> cases in a row. Let's remove them.
>
Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> ---
> sound/xen/xen_snd_front.c | 4 ----
> sound/xen/xen_snd_front_evtchnl.c | 4 ----
> 2 files changed, 8 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> index e21d0bfafeae..228d82031297 100644
> --- a/sound/xen/xen_snd_front.c
> +++ b/sound/xen/xen_snd_front.c
> @@ -246,11 +246,8 @@ static void sndback_changed(struct xenbus_device *xb_dev,
>
> switch (backend_state) {
> case XenbusStateReconfiguring:
> - /* fall through */
> case XenbusStateReconfigured:
> - /* fall through */
> case XenbusStateInitialised:
> - /* fall through */
> break;
>
> case XenbusStateInitialising:
> @@ -289,7 +286,6 @@ static void sndback_changed(struct xenbus_device *xb_dev,
> break;
>
> case XenbusStateUnknown:
> - /* fall through */
> case XenbusStateClosed:
> if (xb_dev->state == XenbusStateClosed)
> break;
> diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
> index 102d6e096cc8..29e0f0ea67eb 100644
> --- a/sound/xen/xen_snd_front_evtchnl.c
> +++ b/sound/xen/xen_snd_front_evtchnl.c
> @@ -46,13 +46,9 @@ static irqreturn_t evtchnl_interrupt_req(int irq, void *dev_id)
> continue;
> switch (resp->operation) {
> case XENSND_OP_OPEN:
> - /* fall through */
> case XENSND_OP_CLOSE:
> - /* fall through */
> case XENSND_OP_READ:
> - /* fall through */
> case XENSND_OP_WRITE:
> - /* fall through */
> case XENSND_OP_TRIGGER:
> channel->u.req.resp_status = resp->status;
> complete(&channel->u.req.completion);
> --
> 2.16.4
>
