Re: [PATCH] ASoC: rt286: fix unexpected interrupt happens

[Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>]

On 7/9/20 5:13 AM, shumingf@xxxxxxxxxxx wrote:
> From: Shuming Fan <shumingf@xxxxxxxxxxx>
>
> The HV/VREF should not turn off if the headphone jack plug-in.
> This patch could solve the unexpected interrupt issue in some devices.
>
> Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

For more context, this patch removes a recurring click with a ~1s period 
audible with headphones on Dell XPS13-9343.

> Signed-off-by: Shuming Fan <shumingf@xxxxxxxxxxx>
> ---
>   sound/soc/codecs/rt286.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
> index 9593a9a27bf8..e8d14eefc41b 100644
> --- a/sound/soc/codecs/rt286.c
> +++ b/sound/soc/codecs/rt286.c
> @@ -272,13 +272,13 @@ static int rt286_jack_detect(struct rt286_priv *rt286, bool *hp, bool *mic)
>   		regmap_read(rt286->regmap, RT286_GET_MIC1_SENSE, &buf);
>   		*mic = buf & 0x80000000;
>   	}
> -	if (!*mic) {
> +
> +	if (!*hp) {
>   		snd_soc_dapm_disable_pin(dapm, "HV");
>   		snd_soc_dapm_disable_pin(dapm, "VREF");
> -	}
> -	if (!*hp)
>   		snd_soc_dapm_disable_pin(dapm, "LDO1");
> -	snd_soc_dapm_sync(dapm);
> +		snd_soc_dapm_sync(dapm);
> +	}
>   
>   	return 0;
>   }