On Tue, 7 Jul 2020, Takashi Iwai wrote: > On Thu, 02 Jul 2020 11:53:51 +0200, > Mark Hills wrote: > > > > Takashi, my apologies, it looks like this patch broke the build of the > > Mona driver. > > > > Thankfully the change is simple, as it just looks like a bit of confusion > > of responsibilies in the code for the Mona interface; the correct fix is > > to remove the code. > > > > That is a lesson for working with only the echo3g driver enabled. Now I > > have done a full build of all echoaudio drivers, with no warnings or > > errors. > > > > Here's a patch, or it can be squashed into the original patch if > > necessary. > > Could you rather fold the fix into the patch and resubmit the whole > patch set? I'm just back from travel, and it'd be better anyway if I > receive a fresh patch set to apply. No problem, I'll follow up. In the end, I decided it best to keep the patch separate, but re-order so as to not break the build. -- Mark
