On Tue 07 Jul 2020 at 21:23, Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote: > This is a much smaller set of cleanups, all related to warnings thrown > by the use of GENMASK() with an unsigned variable. I just made the > warning go away but I wonder if there's a better fix in the definition > of GENMASK() itself? Looking at the patch I was going to ask the same thing. It does not make much sense to me to force GENMASK arguments to be integer (instead of unsigned integer) to then check there are positive ... > > Pierre-Louis Bossart (3): > ASoC: Intel: Skylake: remove comparison always false warning > ASoC: meson: axg-pdm: remove comparison always false warning > ASoC: meson: axg-spdifin: remove comparison always false warning > > sound/soc/intel/skylake/skl-sst-dsp.c | 2 +- > sound/soc/meson/axg-pdm.c | 2 +- > sound/soc/meson/axg-spdifin.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-)