On Fri, 03 Jul 2020 10:00:04 +0200, Benjamin Poirier wrote: > > 1) > In snd_hda_pick_fixup(), quirks are first matched by PCI SSID and then, if > there is no match, by codec SSID. The Lenovo "ThinkPad X1 Carbon 7th" has > an audio chip with PCI SSID 0x2292 and codec SSID 0x2293[1]. Therefore, fix > the quirk meant for that device to match on .subdevice == 0x2292. > > 2) > The "Thinkpad X1 Yoga 7th" does not exist. The companion product to the > Carbon 7th is the Yoga 4th. That device has an audio chip with PCI SSID > 0x2292 and codec SSID 0x2292[2]. Given the behavior of > snd_hda_pick_fixup(), it is not possible to have a separate quirk for the > Yoga based on SSID. Therefore, merge the quirks meant for the Carbon and > Yoga. This preserves the current behavior for the Yoga. > > [1] This is the case on my own machine and can also be checked here > https://github.com/linuxhw/LsPCI/tree/master/Notebook/Lenovo/ThinkPad > https://gist.github.com/hamidzr/dd81e429dc86f4327ded7a2030e7d7d9#gistcomment-3225701 > [2] > https://github.com/linuxhw/LsPCI/tree/master/Convertible/Lenovo/ThinkPad > https://gist.github.com/hamidzr/dd81e429dc86f4327ded7a2030e7d7d9#gistcomment-3176355 > > Fixes: d2cd795c4ece ("ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen") > Fixes: 54a6a7dc107d ("ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga X1 7th gen") > Cc: Jaroslav Kysela <perex@xxxxxxxx> > Cc: Kailang Yang <kailang@xxxxxxxxxxx> > Tested-by: Vincent Bernat <vincent@xxxxxxxxx> > Tested-by: Even Brenden <evenbrenden@xxxxxxxxx> > Signed-off-by: Benjamin Poirier <benjamin.poirier@xxxxxxxxx> Applied this one alone for now. Let me check the second patch later. thanks, Takashi
