Re: [PATCH v2 07/10] topology: decode: Fix decoding PCM formats and rates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/6/20 4:06 AM, Piotr Maziarz wrote:
Not checking _LAST format and rate, which are valid indexes in arrays,
makes data loss while converting binary to UCM.

In the previous version you were decoding to UML. I presume this was typo, but now what does decoding a topology binary to UCM means? Did you really mean UCM as in Use Case Management (https://www.alsa-project.org/alsa-doc/alsa-lib/group__ucm.html)

Change-Id: I71ac42b65e8b1d79f2a061f805c62e29a758ad74
---
  src/topology/pcm.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/topology/pcm.c b/src/topology/pcm.c
index b15b950..db40114 100644
--- a/src/topology/pcm.c
+++ b/src/topology/pcm.c
@@ -549,7 +549,7 @@ int tplg_save_stream_caps(snd_tplg_t *tplg ATTRIBUTE_UNUSED,
  	if (err >= 0 && sc->formats) {
  		err = tplg_save_printf(dst, pfx, "\tformats '");
  		first = 1;
-		for (i = 0; err >= 0 && i < SND_PCM_FORMAT_LAST; i++) {
+		for (i = 0; err >= 0 && i <= SND_PCM_FORMAT_LAST; i++) {
  			if (sc->formats & (1ULL << i)) {
  				s = snd_pcm_format_name(i);
  				err = tplg_save_printf(dst, NULL, "%s%s",
@@ -563,7 +563,7 @@ int tplg_save_stream_caps(snd_tplg_t *tplg ATTRIBUTE_UNUSED,
  	if (err >= 0 && sc->rates) {
  		err = tplg_save_printf(dst, pfx, "\trates '");
  		first = 1;
-		for (i = 0; err >= 0 && i < SND_PCM_RATE_LAST; i++) {
+		for (i = 0; err >= 0 && i <= SND_PCM_RATE_LAST; i++) {
  			if (sc->rates & (1ULL << i)) {
  				s = get_rate_name(i);
  				err = tplg_save_printf(dst, NULL, "%s%s",




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux