On 2020-07-03 12:33 +0200, Jaroslav Kysela wrote: [...] > > @@ -7559,8 +7606,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > > SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), > > SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST), > > - SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK), > > - SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_THINKPAD_HEADSET_JACK), > > + SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Carbon 7th", ALC295_FIXUP_TPX17_DUAL_SPEAKERS), > > + SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_SPEAKER2_TO_DAC1), > > It will cause regression with the old UCM configs. Yes, good point. I'll try to find a way that doesn't need ucm changes. > I would preper the manual > model selection and switch this when things settle a bit in the user space. > We definitely need a better way to control this volume separately for both > tweeters and the bass speakers in the user space. The "Master" volume hack > is far from the ideal solution. [...] > > > The volume control for PCM-OUT2 is renamed to reflect its dual effect. > > This name is also used in a modified alsa UCM profile. [4] > > The new name is not ideal. Perhaps, a mirror (joined) control might be > better in this case. I mean to create both "Bass Speaker Playback Volume" > and "Headphone Playback Volume" with the similar NID control. > > Or create "Speaker Playback" controls with 4 channels (and joined "Headphone > Playback" controls). I'll look into that. As I'm working on this in my spare time, no guarantee on how long it'll take. Thanks for the review.