On 7/1/20 1:44 PM, Mark Brown wrote:
On Wed, Jul 01, 2020 at 01:37:16PM -0500, Pierre-Louis Bossart wrote:
Fix W=1 warning. The VOIP controls were not used in the mainline but
in special versions of Android. Keep and use __maybe_used to make
warning go away.
Why not just remove them?
You'll see a lot of patches where tools report variables/tables as not
used, or not really necessary, it's not clear to me how to deal with
such cases, so I preferred to err on the side of caution.
I honestly don't know if those products are maintained and by whom. I
personally have no issue removing this variable, but I've been surprised
to see 'old' products get a kernel upgrade so when in doubt...
