Hi Mark, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on sound/for-next] [also build test WARNING on v5.8-rc3 next-20200701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mark-Hills/echoaudio-Race-conditions-around-opencount/20200701-203413 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from sound/pci/echoaudio/mona.c:123: sound/pci/echoaudio/mona_dsp.c: In function 'set_input_clock': sound/pci/echoaudio/mona_dsp.c:305:18: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types] 305 | if (atomic_read(&chip->opencount)) | ^~~~~~~~~~~~~~~~ | | | unsigned int * In file included from include/linux/atomic.h:7, from include/linux/cpumask.h:13, from include/linux/interrupt.h:8, from sound/pci/echoaudio/mona.c:37: arch/mips/include/asm/atomic.h:28:55: note: expected 'const atomic_t *' {aka 'const struct <anonymous> *'} but argument is of type 'unsigned int *' 28 | static __always_inline type pfx##_read(const pfx##_t *v) \ | ~~~~~~~~~~~~~~~^ >> arch/mips/include/asm/atomic.h:49:1: note: in expansion of macro 'ATOMIC_OPS' 49 | ATOMIC_OPS(atomic, int) | ^~~~~~~~~~ cc1: some warnings being treated as errors vim +/ATOMIC_OPS +49 arch/mips/include/asm/atomic.h ^1da177e4c3f41 include/asm-mips/atomic.h Linus Torvalds 2005-04-16 47 1da7bce8591d58 arch/mips/include/asm/atomic.h Paul Burton 2019-10-01 48 #define ATOMIC_INIT(i) { (i) } 1da7bce8591d58 arch/mips/include/asm/atomic.h Paul Burton 2019-10-01 @49 ATOMIC_OPS(atomic, int) ^1da177e4c3f41 include/asm-mips/atomic.h Linus Torvalds 2005-04-16 50 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
