>
> this doesn't look too good, the only difference is the addition of
> MAX98090 which should be added in
> SND_SOC_INTEL_DA7219_MAX98357A_GENERIC
> above.
Will do
>
> i don't think you need a different top-level config, just extend the existing
> one to say MAX98357A or MAX98390.
>
> [...]
>
OK. I'll modify the description for MAX98390
>
> these look like unrelated changes?
>
>
Will revert those changes.
>
> That looks just wrong?
>
> It would be really odd to list two devices as prerequisites for loading a driver,
> when in practice they are mutually exclusive? Something's broken in
> coreboot if both are present.
>
> see below what we used for JSL:
>
> see static struct snd_soc_acpi_codecs jsl_7219_98373_codecs = {
> .num_codecs = 1,
> .codecs = {"MX98373"}
> };
>
> static struct snd_soc_acpi_codecs mx98360a_spk = {
> .num_codecs = 1,
> .codecs = {"MX98360A"}
> };
Err... I misread the snd_soc_acpi_codec_list function and made this error. Will
fix it in the V2 patch. I will also fix the Chrome v4.19 branch. Thank you for the
review.
Regards,
Brent
