Re: [PATCH v4 08/23] ASoC: soc-core: Fix component name_prefix parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/29/2020 6:08 AM, Kuninori Morimoto wrote:
External email: Use caution opening links or attachments


Hi Sameer

Thank you for your patch

# I guess there was ML registering magic until v3 ?
# This is 1st time for me to get this patch series...

Until v3 the series was mostly about registering ASoC components. Based on the discussions in the previous series and threads, I have updated drivers to work with DPCM and added patches for simple-card driver to test complete audio path. Yes, simple-card driver patches are new and were not part of earlier series. Sorry if I was not clear in the cover letter.

Thank you for the review.

The "prefix" can be defined in DAI link node or it can be specified as
part of the component node itself. Currently "sound-name-prefix" defined
in a component is not taking effect. Actually the property is not getting
parsed. It can be fixed by parsing "sound-name-prefix" property whenever
"prefix" is missing in DAI link Codec node.

Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
(snip)
@@ -1111,8 +1111,10 @@ static void soc_set_name_prefix(struct snd_soc_card *card,
               struct snd_soc_codec_conf *map = &card->codec_conf[i];

               if (snd_soc_is_matching_component(&map->dlc, component)) {
-                     component->name_prefix = map->name_prefix;
-                     return;
+                     if (map->name_prefix) {
+                             component->name_prefix = map->name_prefix;
+                             return;
+                     }
               }
       }
This is nit-pick but it can be like this ?

                 if (snd_soc_is_matching_component(&map->dlc, component) &&
                     map->name_prefix) {
                         ...
                 }

Sounds fine. Will update.

Thank you for your help !!

Best regards
---
Kuninori Morimoto




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux