Re: [alsa-cvslog] alsa-kernel: cmipci: disable "Modem" control on version 39 or newer chips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thierry Vignaud wrote:
> Clemens Ladisch <clemens@xxxxxxxxxx> writes:
> > description:
> > cmipci: disable "Modem" control on version 39 or newer chips
> > 
> > On version 39 or newer chips, we better remove the "Modem" control
> > because this register bit now mutes the front channels of the
> > multichannel stream.
> 
> shouldn't that deserve a comment in the code?

Not in my opinion.  The "if (version < 39)" makes clear in which version
the control is used, and both the old and new bits are documented in the
respective data sheets. 


Regards,
Clemens
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux