Re: [PATCH v3] ASoC: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 19/06/2020 04:14, John Stultz wrote:
CROS_EC isn't strictly required for audio to work
on other SDM845 platforms (like the Dragonboard 845c).

So lets remove the dependency and select the related
CROS_EC options via imply.

Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Cc: Rohit kumar <rohitkr@xxxxxxxxxxxxxx>
Cc: Patrick Lai <plai@xxxxxxxxxxxxxx>
Cc: Banajit Goswami <bgoswami@xxxxxxxxxxxxxx>
Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
Cc: Mark Brown <broonie@xxxxxxxxxx>
Cc: Jaroslav Kysela <perex@xxxxxxxx>
Cc: Takashi Iwai <tiwai@xxxxxxxx>
Cc: alsa-devel@xxxxxxxxxxxxxxxx
Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
---

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>


v2: Switch to using imply as suggested by Srinivas
---
  sound/soc/qcom/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index f51b28d1b94d..0ea4cde9f4f0 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -99,12 +99,12 @@ config SND_SOC_MSM8996
config SND_SOC_SDM845
  	tristate "SoC Machine driver for SDM845 boards"
-	depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE
+	depends on QCOM_APR && I2C && SOUNDWIRE
  	select SND_SOC_QDSP6
  	select SND_SOC_QCOM_COMMON
  	select SND_SOC_RT5663
  	select SND_SOC_MAX98927
-	select SND_SOC_CROS_EC_CODEC
+	imply SND_SOC_CROS_EC_CODEC
  	help
  	  To add support for audio on Qualcomm Technologies Inc.
  	  SDM845 SoC-based systems.




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux