On Tue, Jun 16, 2020 at 1:25 AM Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote: > On 16/06/2020 07:34, John Stultz wrote: > > CROS_EC isn't strictly required for audio to work > > on other SDM845 platforms (like the Dragonboard 845c). > > > > So lets remove the dependency and select the related > > CROS_EC options if CROS_EC is already enabled. > > Sorry John, totally missed this one out! No worries! > > diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig > > index f51b28d1b94d..0434f2c7d746 100644 > > --- a/sound/soc/qcom/Kconfig > > +++ b/sound/soc/qcom/Kconfig > > @@ -99,12 +99,12 @@ config SND_SOC_MSM8996 > > > > config SND_SOC_SDM845 > > tristate "SoC Machine driver for SDM845 boards" > > - depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE > > + depends on QCOM_APR && I2C && SOUNDWIRE > > select SND_SOC_QDSP6 > > select SND_SOC_QCOM_COMMON > > select SND_SOC_RT5663 > > select SND_SOC_MAX98927 > > - select SND_SOC_CROS_EC_CODEC > > + select SND_SOC_CROS_EC_CODEC if CROS_EC > > Isn't "imply SND_SOC_CROS_EC_CODEC" better option here? I've honestly not gotten my head around "imply", so I'll have to take a closer look. What I have in this patch least is easier to compare and match with the existing code. :) Thanks for the feedback! -john
