On Mon, Jun 15, 2020 at 11:24:33AM +0800, jack.yu@xxxxxxxxxxx wrote:
> +enum {
> + Enable_Boost,
> + Bypass_Boost,
> +};
This cleanup is nice but you should namespace the values here to ensure
they don't collide with anything. We'd also tend to use all caps for
enum items, same as macro names.
You should probably also explicitly assign the values for the constants
to make sure it's clear how they line up with the control the user can
see, eg:
RT1015_ENABLE_BOOST = 0,
Attachment:
signature.asc
Description: PGP signature
