At Mon, 3 Dec 2007 17:30:10 +0200,
Andy Shevchenko wrote:
>
> Hi!
>
> I think the following notices should be reviewed as a typo fix.
> Could you tell me do I wrong?
No, you're obviously correct.
> /* patch_realtek.c */
> ...
> static struct snd_pci_quirk alc861_cfg_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC861_3ST),
> SND_PCI_QUIRK(0x1043, 0x1335, "ASUS F2/3", ALC861_ASUS_LAPTOP),
> SND_PCI_QUIRK(0x1043, 0x1338, "ASUS F2/3", ALC861_ASUS_LAPTOP),
> SND_PCI_QUIRK(0x1043, 0x13d7, "ASUS A9rp", ALC861_ASUS_LAPTOP),
> >>> SND_PCI_QUIRK(0x1584, 0x9075, "Airis Praxis N1212", ALC861_ASUS_LAPTOP),
> SND_PCI_QUIRK(0x1043, 0x1393, "ASUS", ALC861_ASUS),
> SND_PCI_QUIRK(0x1043, 0x81cb, "ASUS P1-AH2", ALC861_3ST_DIG),
> SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba", ALC861_TOSHIBA),
> /* FIXME: the entry below breaks Toshiba A100 (model=auto works!)
> * Any other models that need this preset?
> */
> /* SND_PCI_QUIRK(0x1179, 0xff10, "Toshiba", ALC861_TOSHIBA), */
> SND_PCI_QUIRK(0x1584, 0x9072, "Uniwill m31", ALC861_UNIWILL_M31),
> >>> SND_PCI_QUIRK(0x1584, 0x9075, "Uniwill", ALC861_UNIWILL_M31),
> SND_PCI_QUIRK(0x1584, 0x2b01, "Uniwill X40AIx", ALC861_UNIWILL_M31),
> SND_PCI_QUIRK(0x1849, 0x0660, "Asrock 939SLI32", ALC660_3ST),
> SND_PCI_QUIRK(0x8086, 0xd600, "Intel", ALC861_3ST),
> SND_PCI_QUIRK(0x1462, 0x7254, "HP dx2200 (MSI MS-7254)", ALC861_3ST),
> SND_PCI_QUIRK(0x1462, 0x7297, "HP dx2250 (MSI MS-7297)", ALC861_3ST),
> {}
> };
> ...
>
> The second record was added by myself (I filed bug report) when I discover
> RoverBook Voyager V200. First one was added later without checks.
This one is no typo but a conflct I overlooked.
Can you check whether model works better?
Both models are almost same but have just slight differences...
> And the lines at the same file
>
> ...
> /*
> * generic initialization of ADC, input mixers and output mixers
> */
> static struct hda_verb alc883_auto_init_verbs[] = {
> ...
> /* FIXME: use matrix-type input source selection */
> /* Mixer elements: 0x18, 19, 1a, 1b, 1c, 1d, 14, 15, 16, 17, 0b */
> /* Input mixer1 */
> {0x23, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
> {0x23, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(1)},
> {0x23, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(2)},
> /* {0x23, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(3)}, */
> {0x23, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(4)},
> /* Input mixer2 */
> {0x22, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
> {0x22, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(1)},
> {0x22, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(2)},
> /* {0x22, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(3)}, */
> >>> {0x23, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(4)},
>
> { }
> };
>
> The same initialization is present above in few lines.
Yeah, that should be a typo. Will fix it soon.
Thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
