On Wed, 10 Jun 2020 18:29:12 +0200, Laurence Tratt wrote: > > On Wed, Jun 10, 2020 at 04:49:14PM +0300, Alexander Tsoy wrote: > > Hello Alexander, > > > Thanks! So SSL 2+ is indeed currently needs implicit feedback quirk. > > The question is why it didn't help in your case. > > It didn't work because I was an idiot and used the wrong manufacturer ID. > When I fixed that typo, the drift disappeared. Patch attached! Great, care to submit the patch in a proper format? > [It's reasonable to assume that this will also work for the SSL2, but I > don't know its ID: it might use the same ID as the SSL2+ or perhaps its > 0x0001. Unfortunately I suspect we'll have to wait until one is observed in > the wild to know.] Yes, the addition can be done easily at any time, so let's take the known working one at first. thanks, Takashi > > > Laurie > > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index 8a05dcb134..abf726c49f 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -367,6 +367,7 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs, > ifnum = 0; > goto add_sync_ep_from_ifnum; > case USB_ID(0x07fd, 0x0008): /* MOTU M Series */ > + case USB_ID(0x31e9, 0x0002): /* Solid State Logic SSL2+ */ > ep = 0x81; > ifnum = 2; > goto add_sync_ep_from_ifnum; >
