Hi Mark, Ranjani again > > > > This is change is justified in one way but it also feels like maybe > > > > because the functions are so specific to compr devices, it is best to > > > > leave them here. Maybe others should also chime in. > (snip) > > I don't think there's one right answer here. I guess if we have to pick > > we should do the same as is being done for PCM for compressed open but > > either option is fine I think. > > I re-checked the patch. > The original code is soc_compr_xxx() and doing compress things. > I agree to keeping original code at original file. > I will remove these patched from v2 patch-set. I re-re-checked. I will drop this patch this time, but might post it again in the future. Because we already have same/similar functon for DAI (= snd_soc_dai_compr_xxx()). And I plan to add snd_soc_component_xxx() specific future, and compr can use it. Thank you for your help !! Best regards --- Kuninori Morimoto