> -----Original Message----- > From: Takashi Iwai <tiwai@xxxxxxx> > Sent: Wednesday, June 3, 2020 8:24 PM > To: Steve Lee <SteveS.Lee@xxxxxxxxxxxxxxxxxxx> > Cc: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; perex@xxxxxxxx; > tiwai@xxxxxxxx; ckeepax@xxxxxxxxxxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx; > rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx; shumingf@xxxxxxxxxxx; > srinivas.kandagatla@xxxxxxxxxx; krzk@xxxxxxxxxx; dmurphy@xxxxxx; > jack.yu@xxxxxxxxxxx; nuno.sa@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > alsa-devel@xxxxxxxxxxxxxxxx; ryan.lee.maxim@xxxxxxxxx; Ryan Lee > <RyanS.Lee@xxxxxxxxxxxxxxxxxxx>; steves.lee.maxim@xxxxxxxxx > Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw > loading > > EXTERNAL EMAIL > > > > On Wed, 03 Jun 2020 13:18:19 +0200, > Steve Lee wrote: > > > > @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component > *component) > > > > /* Dsm Setting */ > > regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94); > > - regmap_write(max98390->regmap, DSMIG_EN, 0x19); > > Is this change intentional? > It wasn't mentioned in the patch description. It should be another change. I will re-send the patch. > > > thanks, > > Takashi
