Shall move on with the graph card and shall submit the changes. -----Original Message----- From: Mark Brown <broonie@xxxxxxxxxx> Sent: Tuesday, May 19, 2020 1:10 AM To: Sia, Jee Heng <jee.heng.sia@xxxxxxxxx> Cc: alsa-devel@xxxxxxxxxxxxxxxx; tiwai@xxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxxxxxxxx Subject: Re: [PATCH v2 2/4] ASoC: Intel: Boards: Add KeemBay machine driver On Mon, May 18, 2020 at 10:17:20AM +0800, Sia Jee Heng wrote: > Add KeemBay machine driver which glues the tlv320aic3204 codec driver > and kmb_platform driver to form the asoc sound driver. Why do you need a custom machine driver for this, as this is a DT based platform and I'm not seeing anything complex or unusual in the code you should be able to use audio-graph-card (or simple-card but the former is more modern and should be preferred for new systems). If this is required the DT binding should be documented.
