Hi Ranjani, again > > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > > > Current ALSA SoC has some snd_soc_card_xxx() functions, > > > and card->xxx() callbacks. > > > But, it is implemented randomly at random place. > > > > > > To collect all card related functions into one place, > > > this patch creats new soc-card.c. > > > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > --- > (snip) > > > #include <sound/soc-component.h> > > > +#include <sound/soc-card.h> > > Morimoto-san, > > > > soc-card.h should be added where it is needed. For example, in this > > patch, it should be included in soc-card.c and in the following > > patches, it should be included in soc-core.c, soc-dapm.c etc where it > > is needed. Hmm.... it seesm too many drivers are using snd_soc_card_xxx(). This means, I / this patch-set need to add too many #included <sound/soc-card.h> line at too many files... soc-component already did, but keeping it at soc.h is more simple for some of them. So, I want to keep it in v2 Thank you for your help !! Best regards --- Kuninori Morimoto