Re: [PATCH v2 0/7] ASoC: add soc-link

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-05-21 at 10:55 +0900, Kuninori Morimoto wrote:
> Hi Mark
> 
> Current ALSA SoC is handling dai_link related operation,
> but it is implmemented directly without using function/macro,
> and at random place.
> 
> This v2 patch-set creates new snd_soc_link_xxx() functions
> which handles dai_link related operation,
> and implmement these at new soc-link.c.
> 
> v1 -> v2
> 	- #include <sound/soc-link.h> is added on each c source file
> 	  instead of soc.h
> 	- not have extra error message after snd_soc_link_xxx(),
> 	  because it already indicate it via snc_link_ret()
> 	- snd_soc_link_compr_xxx() doesn't have rtd parameter,
> 	  because it can be created from cstream
> 
> Link: 
> https://lore.kernel.org/r/877dx868op.wl-kuninori.morimoto.gx@xxxxxxxxxxx
> 
> Kuninori Morimoto (7):
>   ASoC: add soc-link.c
>   ASoC: soc-link: move soc_rtd_xxx()
>   ASoC: soc-link: remove unneeded parameter from snd_soc_link_xxx()
>   ASoC: soc-link: add snd_soc_link_be_hw_params_fixup()
>   ASoC: soc-link: add snd_soc_link_compr_startup()
>   ASoC: soc-link: add snd_soc_link_compr_shutdown()
>   ASoC: soc-link: add snd_soc_link_compr_set_params()

The series LGTM except for the missing include for soc-link.h in soc-
link.c. Thanks, Morimoto-san.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux