At Tue, 27 Nov 2007 17:43:05 +0100, I wrote: > > At Fri, 16 Nov 2007 00:07:00 +0100, > Ctirad Fertr wrote: > > > > Hello, > > > > this patch improves E-Mu 1616(M) cardbus support. It adds definitions of the > > new Microdock and 1010 cardbus registers (thanks again for descriptions > > James) and improves mixer for this card. Now you can use S/PDIF and ADAT on > > Mirodock and also use headpohone output on host cardbus card as another > > independent output. > > > > Signed-off-by: Ctirad Fertr <c.fertr@xxxxxxxxx> > > The changes look almost good to me. But, if I understand correctly, > the input source put isn't changed properly for EMU1616. > > The patch below is the revised version with bunch of coding style > fixes (at the next time, try scripts/checkpatch.pl in linux kernel > tree before submission). > Let me know if it works for you. I'll apply to ALSA tree after your > confirmation. > > > Thanks, > > Takashi Oh, BTW, it'd be also appreciated if you can write an additional patch to add enum definitions for each emu_model type instead of digits. "if (emu_model == 3)" is no good style. Thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
