[AMD Official Use Only - Internal Distribution Only] > -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Tuesday, May 19, 2020 5:04 PM > To: Mukunda, Vijendar <Vijendar.Mukunda@xxxxxxx> > Cc: alsa-devel@xxxxxxxxxxxxxxxx; tiwai@xxxxxxx; Deucher, Alexander > <Alexander.Deucher@xxxxxxx> > Subject: Re: [PATCH v3 09/14] ASoC: amd: add Renoir ACP PCI driver PM ops > > On Tue, May 19, 2020 at 01:16:59AM +0800, Vijendar Mukunda wrote: > > > + ret = rn_acp_deinit(adata->acp_base); > > + if (ret) > > + dev_err(dev, "ACP de-init failed\n"); > > + else > > + dev_dbg(dev, "ACP de-initialized\n"); > > We should return the error code if we fail to suspend. Will fix it and update a fresh patch.