-----Original Message----- From: Mark Brown <broonie@xxxxxxxxxx> Sent: Monday, May 11, 2020 7:34 PM To: Sia, Jee Heng <jee.heng.sia@xxxxxxxxx> Cc: alsa-devel@xxxxxxxxxxxxxxxx; tiwai@xxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxxxxxxxx Subject: Re: [PATCH 4/4] dt-bindings: sound: Add documentation for KeemBay sound card and i2s On Mon, May 11, 2020 at 11:16:04AM +0800, Sia Jee Heng wrote: > +description: | > + Intel KeemBay I2S > + > +properties: > + compatible: > + enum: > + - snps,designware-i2s If this is the DesignWare I2S controller we already have a driver for that with existing DT bindings, anything that needs to be added should be added to that. We can't have multiple sets of bindings for the same device. [>>] Sorry for the confusion, I meant intel,keembay-i2s. Shall submit the fix.