Re: [PATCH] ASoC: Intel: Skylake: Update description for HDaudio kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-05-06 22:57, Pierre-Louis Bossart wrote:


On 5/6/20 3:52 PM, Cezary Rojewski wrote:
With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied,
warning is no longer true. Remove it and update the description.

Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
---
  sound/soc/intel/Kconfig | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index c8de0bb5bed9..4d11f4f3f7e2 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -209,12 +209,8 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK
  config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
      bool "HDAudio codec support"
      help
-      This option broke audio on Linus' Skylake laptop in December 2018
-      and the race conditions during the probe were not fixed since.
-      This option is DEPRECATED, all HDaudio codec support needs
-      to be handled by the SOF driver.
-      Distributions should not enable this option and there are no known
-      users of this capability.
+      If you have Intel Skylake or Kabylake with HDaudio codec

I would have added HDaudio codec + dmic but that's good enough, the selection based on DMIC presence will be done by your other patch so

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

Thanks Cezary.


+      then enable this option by saying Y or m.
  config SND_SOC_INTEL_SKYLAKE_COMMON
      tristate


Do you want me to spin v3? While copying desc from other kconfgs, I added 'or m' by mistake. Don't mind to update once more if you want me to.

Czarek



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux