On 2020-05-06 22:30, Pierre-Louis Bossart wrote:
On 5/6/20 2:55 PM, Cezary Rojewski wrote:
This reverts commit 02701b909c2fab4b49f9c9545ab921c9b2c7a768.
With 'ASoC: Intel: Skylake: Fix HDaudio and Dmic' series applied,
warning is no longer true. Remove it.
Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
---
sound/soc/intel/Kconfig | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index c8de0bb5bed9..d6c5c68b7499 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -209,12 +209,9 @@ config SND_SOC_INTEL_SKYLAKE_SSP_CLK
config SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
bool "HDAudio codec support"
help
- This option broke audio on Linus' Skylake laptop in December 2018
- and the race conditions during the probe were not fixed since.
- This option is DEPRECATED, all HDaudio codec support needs
- to be handled by the SOF driver.
- Distributions should not enable this option and there are no known
- users of this capability.
+ If you have a Intel Skylake/Broxton/ApolloLake/KabyLake/
+ GeminiLake or CannonLake platform with an HDaudio codec
+ then enable this option by saying Y
Yes we need to change the help text now that the issues were fixed and
UCM/topology are available, but I would be more comfortable if the text
was aligned with your patch "[PATCH] ALSA: hda: Allow SST driver on SKL
and KBL platforms with DMIC"
e.g. If you have a Intel Skylake or KabyLake plaforms with an HDaudio
codec+DMIC configuration then enable this option by saying Y
Agreed. That makes patch a revert no longer, though. Re-sent as:
ASoC: Intel: Skylake: Update description for HDaudio kconfig
Thanks, Czarek
