On Sat 02 May 2020 at 16:09, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, May 02, 2020 at 09:47:21AM -0400, Sasha Levin wrote:
>> On Fri, May 01, 2020 at 01:25:36PM +0100, Mark Brown wrote:
>> > On Fri, May 01, 2020 at 12:57:27PM +0100, Guillaume Tucker wrote:
>> >
>> > > The call stack is not the same as in the commit message found by
>> > > the bisection, so maybe it only fixed part of the problem:
>> >
>> > No, it is a backport which was fixing an issue that wasn't present in
>> > v5.4.
>> >
>> > > > Result: 09f4294793bd3 ASoC: meson: axg-card: fix codec-to-codec link setup
>> >
>> > As I said in reply to the AUTOSEL mail:
>> >
>> > | > Since the addition of commit 9b5db059366a ("ASoC: soc-pcm: dpcm: Only allow
>> > | > playback/capture if supported"), meson-axg cards which have codec-to-codec
>> > | > links fail to init and Oops:
>> >
>> > | This clearly describes the issue as only being present after the above
>> > | commit which is not in v5.6.
>> >
>> > Probably best that this not be backported.
>>
>> Hrm... But I never queued that commit... I wonder what's up.
>
> I saw the Fixes: tag, but missed the changelog text. My fault.
>
> I'll go drop it from everywhere, sorry about that.
>
> greg k-h
Hi everyone,
Sorry for the mess this seems to have triggered.
Indeed, with the Fixes tag, I understand why the patch has been picked
up. Even I thought that a backport would be OK, since the mistake was
quite old.
If I had wrote it correctly from the start, I would have found the
problem that was waiting for us in ASoC ... but the 2 errors cancelled
each other out.
It is only now that ASoC has been fixed that we found my mistake.
Again, sorry for the mess.
Thanks a lot for your time and effort on this
