On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device *kdev, > struct amdgpu_device *adev = dev->dev_private; > struct drm_audio_component *acomp = data; > > + if (!device_link_add(hda_kdev, kdev, DL_FLAG_STATELESS | > + DL_FLAG_PM_RUNTIME)) { > + DRM_ERROR("DM: cannot add device link to audio device\n"); > + return -ENOMEM; > + } > + Doesn't this duplicate drivers/pci/quirks.c:quirk_gpu_hda() ?