At Thu, 22 Nov 2007 13:06:19 +0000, Mark Brown wrote: > > On Tue, Nov 20, 2007 at 11:42:18AM +0000, Ben Dooks wrote: > > > S3C2412 SoC IIS support for ALSA/ASoC > > > > Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx> > > Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Looks good, thanks - I've applied this to the linux-2.6-asoc tree with > some minor checkpatch.pl cleanups (everything except the line lengths). > > I did notice these: > > > +#define bit_set(v,b) (((v) & (b)) ? 1 : 0) > > > +#define ABS(x) (((x) < 0) ? (-(x)) : (x)) > > which look like they ought to be hoisted out into generic code. Yes, at least, we have already abs() in linux/kernel.h. Not sure about bit_set(), though. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
